Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): Optimize persistence agent to pass yaml directly to db and minio client #1244

Merged
merged 2 commits into from
May 24, 2023
Merged

feat(backend): Optimize persistence agent to pass yaml directly to db and minio client #1244

merged 2 commits into from
May 24, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented May 22, 2023 •
edited
Loading

Which issue is resolved by this Pull Request:
Part of #1227

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@google-oss-prow google-oss-prow bot requested review from jinchihe and pugangxa May 22, 2023 21:30
@Tomcli Tomcli changed the title POC(backend): Optimize persisten agent to pass yaml directly to db and minio client feat(backend): Optimize persistence agent to pass yaml directly to db and minio client May 23, 2023
@Tomcli
Copy link
Member Author

Tomcli commented May 23, 2023

/assign @yhwang

@yhwang
Copy link
Member

yhwang commented May 23, 2023 •
edited
Loading

will reusing and refactoring client_manager.go make sync up difficult? just curious

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhwang
Copy link
Member

yhwang commented May 24, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 24, 2023
@google-oss-prow google-oss-prow bot merged commit f8ebbd4 into kubeflow:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhwang yhwang yhwang approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@pugangxa pugangxa Awaiting requested review from pugangxa

Assignees

@yhwang yhwang

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomcli @yhwang